Skip to content

Fix CI: align vcpkg commit with builtin-baseline, bump Actions to v4 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xarthurx merged 1 commit into from
Apr 1, 2026
Merged

Fix CI: align vcpkg commit with builtin-baseline, bump Actions to v4 #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
CPP_PREBUILD_DIR: cppPrebuild

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
# Try to restore C++ build from cache
- name: Cache C++ Build Artifacts
id: cache-cpp
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
${{ env.CPP_Project }}/build
Expand All @@ -93,7 +93,7 @@ jobs:
if: steps.cache-cpp.outputs.cache-hit != 'true'
uses: lukka/run-vcpkg@v11
with:
vcpkgGitCommitId: ce613c41372b23b1f51333815feb3edd87ef8a8b # 2025-04-09 version
vcpkgGitCommitId: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a # matches builtin-baseline in vcpkg.json
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new comment explains intent, but it removes the previous date-based context and doesn’t identify which vcpkg.json it refers to. To make future maintenance and audits easier, consider expanding the comment to include (a) the path to the vcpkg.json whose builtin-baseline this matches and (b) a human-friendly date (or the baseline value) alongside the commit hash.

Suggested change
vcpkgGitCommitId: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a # matches builtin-baseline in vcpkg.json
vcpkgGitCommitId: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a # matches builtin-baseline in GeoSharPlusCPP/vcpkg.json (builtin-baseline: 5dfa11cf88a8da8877b54fcbc5f6db78bc13f75a, as of 2024-03-01)

Copilot uses AI. Check for mistakes.

# Configure and build using CMake (only if cache miss)
- name: Configure and Build with CMake
Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
YAK_TOKEN: ${{ secrets.YAK_TOKEN }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0

Expand All @@ -240,7 +240,7 @@ jobs:
uses: NuGet/setup-nuget@v2

- name: Setup .NET
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x

Expand Down
Loading