clickbench: EC2 launch configuration comes from the environment - #40
Open
SferaDev wants to merge 2 commits into
Open
clickbench: EC2 launch configuration comes from the environment#40SferaDev wants to merge 2 commits into
SferaDev wants to merge 2 commits into
Conversation
SferaDev
marked this pull request as draft
June 12, 2026 22:41
Provisioning inputs (profile, region, AMI, subnet, security group, key pair) are read from environment variables or the untracked clickbench/.env; nothing account-specific is committed. The serial console gets a random per-launch password instead of a fixed one, the cloud-init wait fails loudly instead of printing success after timing out, and teardown requires an explicit instance name.
SferaDev
force-pushed
the
chore/launch-ec2-hardening
branch
from
June 12, 2026 22:46
3ddc28e to
f1c4620
Compare
SferaDev
changed the title
SferaDev
marked this pull request as ready for review
June 12, 2026 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The clickbench EC2 harness now reads its provisioning inputs — AWS profile, region, AMI, subnet, security group, key pair — from environment variables or the untracked
clickbench/.env(sourced automatically when present). Nothing environment-specific is committed; launching without the required values aborts with guidance before any AWS call.Also:
--terminate-only) requires an explicit--name; all abort checks run before any AWS mutation.clickbench/Makefile:EC2_KEYderives fromKEY_NAME(~/.ssh/<key>.pem) or is passed explicitly; the missing-key error only fires on targets that need it.Testing
bash -nclean; all abort paths exercised without AWS calls (missing config, missing key, terminate-only without name, empty/missing--namevalue, unknown option — each exits 1 with guidance); Makefile dry-runs verified for key derivation, explicitEC2_KEY, and keyless error. No instances launched.A follow-up PR applies the same conventions to
rtabench/andjsonbench/.