fix(report): link advisories in the by-device table and stop it reflowing (4.2.1) - #17
Merged
Merged
Conversation
…wing (4.2.1) Two problems with the bundle report's "By device" appendix, both reported from real use. Expanding a device's "show" disclosure reflowed the whole table. Measured on the reference report: Model lost 47px, Which gained 91px, and every other column shifted. That happens exactly when a reader is comparing rows, so the rows above and below the one being opened slide out from under the cursor. Both appendix tables now use table-layout: fixed with declared column widths. The advisory identifiers were plain text, so a reader working device by device had to scroll back up to the per-advisory rows to reach Cisco. They are now links, opening in a new tab with rel="noreferrer noopener" — the same treatment the per-advisory rows and the whole-fleet report already give them. Fixing the layout exposed a second-order problem: fixed columns squeezed the advisory column to 256px while the longest identifier measures 316px, so all 16 identifiers on the sample device wrapped across three or four lines each. Fixed by giving the tables a 900px floor inside a horizontally scrollable container, and by rebalancing the columns so Which gets 40% (360px at the floor). Identifiers also no longer break mid-token — they are meant to be read and copied whole, unlike the prose cells that still wrap anywhere. Verified in a browser against the 70-row reference report: both tables hold [144, 207, 108, 81, 360] across an expand, each column set sums to exactly 100%, and all 737 identifiers across 55 device rows now sit on one line — up from 1 of 16. Tests 392 -> 402, covering the links, the fixed layout, the min-width floor, the no-mid-token-break rule, and that each column set sums to 100% (a set that does not makes the declared widths advisory rather than fixed). PATCH: presentation only, no verdict or data change. Follows 544629c, which was also a report fix that added new-tab advisory links. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems with the bundle report's "By device" appendix, both reported from real use of 4.2.0.
1. Expanding a row reflowed the whole table
Measured on the reference report before fixing:
That reflow happens exactly when a reader is comparing rows, so the rows above and below the one being opened slide out from under the cursor. Both appendix tables now use
table-layout: fixedwith declared column widths, verified holding[144, 207, 108, 81, 360]across an expand.2. The advisory identifiers were plain text
A reader working device by device had to scroll back up to the per-advisory rows to reach Cisco. They are now links, opening in a new tab with
rel="noreferrer noopener"— the same treatment the per-advisory rows and the whole-fleet report already give them.The part I didn't expect
Fixing the layout created a worse problem than it solved. Fixed columns squeezed the advisory column to 256px while the longest identifier (
cisco-sa-onprem-fmc-authbypass-5JPp45V2) measures 316px, so all 16 identifiers on the sample device wrapped across three or four lines each. A wide window hides this; a narrow one does not.So there is a second half to the fix:
737 of 737 identifiers across 55 device rows now sit on one line, up from 1 of 16.
Worth noting because the string-level assertions all passed before this was caught — it took rendering the real report in a browser and measuring.
Verification
Verified in a browser against the 70-row reference report:
Tests 392 → 402, covering the links, the fixed layout, the min-width floor, the no-mid-token-break rule, and the column-sum property.
Scope
Presentation only. No verdict, data, or API change; the per-advisory rows, the whole-fleet layout, verdict rules and reason kinds are untouched.
VERSION4.2.0 → 4.2.1 (PATCH), following544629c, which was also a report fix that added new-tab advisory links and bumped PATCH. Tag is pushed only after this merges.🤖 Generated with Claude Code