Conversation
basrieter
left a comment
basrieter
left a comment
There was a problem hiding this comment.
Please start with my initial comments. I (or someone else) will re-review it after the initial fixes.
| @@ -0,0 +1,30 @@ | |||
| --- | |||
There was a problem hiding this comment.
Don't submit .github files in a PR.
| @@ -0,0 +1,18 @@ | |||
| ### Description | |||
There was a problem hiding this comment.
Don't submit github files in a PR.
| @@ -0,0 +1,95 @@ | |||
| ### Introduction | |||
There was a problem hiding this comment.
Don't submit github files in a PR.
service.plexskipintro/addon.xml
Outdated
| <description lang="en">Prompt a Skip Intro dialog Netflix style using plex metadata. Skips intro for your favourite shows</description> | ||
| <summary lang="en">Skip TV Shows Intro</summary> | ||
| <platform>all</platform> | ||
| <forum>-</forum> |
There was a problem hiding this comment.
Fill out all the information and add the SDPX for the license.
| import time | ||
|
|
||
| def closeDialog(): | ||
| global Dialog |
There was a problem hiding this comment.
What are all these globals in this file?
There was a problem hiding this comment.
these globals are being used to pass around values between defs for various variables such as the times of the intro or the dialog to be displayed/hidden
|
Ping @Darkmadda |
Requested as in review suggestion
Requested as in review suggestion
CR fixes
CR fix
|
Resurrecting this. Please squash your commits so that there is only one commit in this. Otherwise we can't review and merge it. |
3 participants
Description
Checklist:
Additional information :