Conversation
|
@kodiai review |
kodiai responseDecision: NOT APPROVED Issues:
|
|
@ualeks please correct the errors from the addon checker and the recommended fix from the KodiAI review. |
db3d5e0 to
2e52509
Compare
|
@pkscout fixed, thanks |
| def _poll_for_authorization(device_code, user_code, expires_in, interval): | ||
| dialog = xbmcgui.DialogProgress() | ||
| dialog.create( | ||
| 'Bingebase', |
There was a problem hiding this comment.
Please consider moving UI strings to strings.po and Addon.getLocalizedString() to obtain a translated variand instead of hardcoded strings.
There was a problem hiding this comment.
Please exclude this file as not relevant to addon functionality
There was a problem hiding this comment.
Please exclude this file as not relevant to addon functionality
|
Please exclude Git-specific files and check my comment about UI strings. It's a recommendation, not a requirement so you can just confirm that hardcoded strings are ok for this addon. |
2e52509 to
c8d0804
Compare
|
@romanvm git files removed, hardcoded strings are ok, thanks! |
c8d0804 to
1830a2b
Compare
Description
Bingebase - Track movies and TV shows to Bingebase.com
Automatically scrobble what you watch in Kodi and sync your watch history with Bingebase.
Features:
Website: https://bingebase.com
Source: https://github.com/ualeks/script.bingebase
Checklist: