Skip to content

[script.bingebase] 1.0.3#2798

Merged
romanvm merged 1 commit intoxbmc:matrixfrom
ualeks:script.bingebase
Mar 21, 2026
Merged

[script.bingebase] 1.0.3#2798
romanvm merged 1 commit intoxbmc:matrixfrom
ualeks:script.bingebase

Conversation

@ualeks
Copy link
Copy Markdown

@ualeks ualeks commented Jan 30, 2026

Description

Bingebase - Track movies and TV shows to Bingebase.com

Automatically scrobble what you watch in Kodi and sync your watch history with Bingebase.

Features:

  • Scrobbling for movies and TV episodes
  • Two-way sync (Kodi ↔ Bingebase)
  • Device authorization flow
  • Scheduled background sync (6h/12h/24h)
  • Sync on startup and library update

Website: https://bingebase.com
Source: https://github.com/ualeks/script.bingebase

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

@pkscout
Copy link
Copy Markdown
Member

pkscout commented Mar 15, 2026

@kodiai review

@kodiai
Copy link
Copy Markdown

kodiai bot commented Mar 15, 2026

kodiai response

Decision: NOT APPROVED

Issues:

@fuzzard fuzzard closed this Mar 15, 2026
@fuzzard fuzzard reopened this Mar 15, 2026
@pkscout
Copy link
Copy Markdown
Member

pkscout commented Mar 15, 2026

@ualeks please correct the errors from the addon checker and the recommended fix from the KodiAI review.

@ualeks ualeks force-pushed the script.bingebase branch from db3d5e0 to 2e52509 Compare March 15, 2026 22:32
@ualeks ualeks changed the title [script.bingebase] 1.0.2 [script.bingebase] 1.0.3 Mar 15, 2026
@ualeks
Copy link
Copy Markdown
Author

ualeks commented Mar 15, 2026

@pkscout fixed, thanks

def _poll_for_authorization(device_code, user_code, expires_in, interval):
dialog = xbmcgui.DialogProgress()
dialog.create(
'Bingebase',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider moving UI strings to strings.po and Addon.getLocalizedString() to obtain a translated variand instead of hardcoded strings.

Comment thread script.bingebase/.gitattributes Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this file as not relevant to addon functionality

Comment thread script.bingebase/.gitignore Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this file as not relevant to addon functionality

@romanvm
Copy link
Copy Markdown

romanvm commented Mar 21, 2026

Please exclude Git-specific files and check my comment about UI strings. It's a recommendation, not a requirement so you can just confirm that hardcoded strings are ok for this addon.

@ualeks ualeks force-pushed the script.bingebase branch from 2e52509 to c8d0804 Compare March 21, 2026 15:15
@ualeks
Copy link
Copy Markdown
Author

ualeks commented Mar 21, 2026

@romanvm git files removed, hardcoded strings are ok, thanks!

@ualeks ualeks force-pushed the script.bingebase branch from c8d0804 to 1830a2b Compare March 21, 2026 15:35
Copy link
Copy Markdown

@romanvm romanvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

del

@romanvm romanvm added Approved Approved and is ready to merge and removed waiting for developer to respond labels Mar 21, 2026
@romanvm romanvm merged commit 03b27e8 into xbmc:matrix Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants