[weather.ozweather@matrix] 2.1.8

[bossanova808]

Add-on details:

• General

  • Add-on name: OzWeather
  • Add-on ID: weather.ozweather
  • Version number: 2.1.8
  • Kodi/repository version: matrix

• Code location

  • URL: https://github.com/bossanova808/weather.ozweather

Weather forecasting and radar images for Australia using Bureau of Meteorology data. For full features (animated radars & ABC weather videos) - make sure you install the replacement skin files - see information at the addon wiki (https://kodi.wiki/index.php?title=Add-on:Oz_Weather).

Description of changes:

v2.1.8

• Add RadarRange label

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

[kodiai]

Kodiai Review Summary

What Changed

This PR adds a new RadarRange label to the OzWeather addon, providing radar range information for weather displays.

Reviewed: core logic, docs

Strengths

• ✅ Clear feature addition with proper version bump from 2.1.7 to 2.1.8 (addon.xml:2)
• ✅ Changelog updated to document the new RadarRange label feature (changelog.txt:1-2)
• ✅ Consistent renaming from RADAR_LOOKUP to RADAR_LOCATION improves code clarity (store.py:108)

Observations

Impact

[CRITICAL] weather.ozweather/resources/lib/store.py (120, 123): Invalid function call on staticmethod
RADAR_RANGE is defined as a @staticmethod but is being called in forecast.py:287 without parentheses, treating it as a property lookup rather than a method call. This will cause the code to retrieve the method object itself rather than execute it, resulting in incorrect data being stored in the WeatherWindow property.

Verdict

🔴 Address before merging -- 1 blocking issue(s) found

Review Details

• Files reviewed: 4
• Lines changed: +96 -67
• Profile: balanced (auto, lines changed: 163)
• Author: newcomer (adapted tone)
• Findings: 1 critical, 0 major, 0 medium, 0 minor (includes 1 from summary observations)
• Review completed: 2026-03-25T03:10:54.382Z
• Keyword parsing:
  • focus hints: [WEATHER.OZWEATHER@MATRIX], [WEATHER.OZWEATHER]

[bossanova808]

@kodiai The line you mention has a method call with parantheses - you are incorrect:

set_property(WEATHER_WINDOW, 'RadarRange', Store.RADAR_RANGE(radar))

[kodiai]

kodiai response

You're absolutely correct, and I apologize for the error.

Looking at the actual code:

• store.py:120-123 defines RADAR_RANGE as a @staticmethod that accepts radar_code as a parameter
• forecast.py:287 calls it correctly with parentheses: Store.RADAR_RANGE(radar)

The method call is valid and my critical issue flag was incorrect. Thank you for catching that.

[basrieter]

See my comment about the removal of the space-char?

[basrieter]

Was this space removal intended?

[bossanova808]

It was intended - it's never been called 'Oz Weather' always 'OzWeather'... apparently I made a typo somewhere back before...well, before Github was even a thing! If it will create problems I can change it back, but it's just niggled at me for like 15 years and suddenly I felt like fixing it. I figured if the addon ID was the same it would just be a cosmetic thing to correct the name, but maybe that is wrong?