[script.xbmcbackup] 1.7.3

[robweber]

Description

• fixed issue with Scheduler running in a loop. Issue stemmed from previous strptime fix affecting correct calculation of cron values
• changed previous strptime bug fix by applying specific patch to authorizers file where this bug was initially seen

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practise but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.

[kodiai]

Kodiai Review Summary

What Changed

Version 1.7.3 fixes scheduler loop issue by refactoring the strptime bug workaround from a global datetime.datetime monkey-patch to a targeted function-based approach.

Reviewed: core logic

Strengths

• ✅ Removes dangerous global mutation of datetime.datetime (authorizers.py:24 removed)
• ✅ Targeted fix reduces side effects - only patches where needed (authorizers.py:153)

Observations

Impact

[MAJOR] script.xbmcbackup/resources/lib/authorizers.py (138, 147-148, 155): Missing resource cleanup - file handles not closed on exception
File handles opened without context managers will leak if exceptions occur during read operations.

Preference

[MINOR] script.xbmcbackup/resources/lib/authorizers.py (153): Optional: Add error handling for strptime parsing
Optional: Wrap patch_strptime() call in try-except to handle malformed date strings gracefully.

Suggestions

• Future consideration: Convert all file operations to use context managers (with statements) for automatic resource cleanup

Verdict

🔴 Address before merging -- 1 blocking issue(s) found (CRITICAL/MAJOR)

Review Details

• Files reviewed: 2
• Lines changed: +6 -11
• Profile: strict (auto, lines changed: 17)
• Author: core (adapted tone)
• Findings: 0 critical, 1 major, 0 medium, 1 minor (includes 2 from summary observations)
• Review completed: 2026-03-30T14:43:30.582Z
• Keyword parsing:
  • focus hints: [SCRIPT.XBMCBACKUP]

[kodiai]

Kodiai Addon Check

Addon	Level	Message
script.xbmcbackup	WARN	403 Client Error: Forbidden for url: https://forum.kodi.tv/showthread.php?tid=129499
script.xbmcbackup	WARN	Complex entry point. Check: default.py
script.xbmcbackup	WARN	We found no problems and 2 warnings, please check the logfile.

0 error(s), 3 warning(s) found.

[robweber]

Fixed file IO issues per AI check.