Skip to content

update to visualization API 5.0.0 and code cleanups#78

Merged
AlwinEsch merged 7 commits into
xbmc:Piersfrom
AlwinEsch:Piers-change
May 22, 2026
Merged

update to visualization API 5.0.0 and code cleanups#78
AlwinEsch merged 7 commits into
xbmc:Piersfrom
AlwinEsch:Piers-change

Conversation

@AlwinEsch

@AlwinEsch AlwinEsch commented May 18, 2026

Copy link
Copy Markdown
Member

Add-on update related to Kodi API change defined on xbmc/xbmc#28278

Further done some few cleanups

Runtime tests on Windows and Linux are OK.

WARNING NOTE

The update from Angle version 3712 to 7258 has brought a crash on it, due this reason leaved on old Angle version for here.
Need to look in future about a newer angle version where works.

@kodiai

kodiai Bot commented May 18, 2026

Copy link
Copy Markdown

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 10 changed files.
Review Details
  • Review plan: ready hash=94be87950539 route=standard task=review.full files=10 lines=963(local-diff) budget=50t/670s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred

  • Review reducer: ready input=1 kept=1 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0

  • Review candidates: shadow recorded=1 rejected=0 errors=0 artifact=present repo=xbmc-visualization.pictureit pr=78 key=kodiai-review-output:v1:inst-109141824:xbmc-visualization.pictureit:pr-78:action delivery=57b57920-5278-11f1-9743-9e4c21783ef1

  • Review candidate publication: mode=blocked approved=1 rewritten=0 published=0 directFallback=0 reasons=candidate-publisher-blocked

  • Files reviewed: 10

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +581 -382

  • Profile: minimal (auto, lines changed: 963)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-operator-truth-paths candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=5d6415de2db86db3 deliveryId=57b57920-5278-11f1-9743-9e4c217… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:3437e95768588750221ae7cac11f3ece; recordKey=candidate-publication-record:3437e95768588750221ae7cac11f3ece; correlationKey=candidate-publication-bridge:a2fe5d4ea7aebd87e25cd3bfc3e03c3e; source=review-handler-publication; candidateRef=candidate-publication-summary-8f91182c; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • M070 candidate verification publication: status=mixed; counts=attempted:1,allowed:0,denied:1,published:0,skipped:1,failed:0; verification=verified:0,partially_verified:0,unverified:1,disproven:0,unavailable:0; candidateVerification=candidateCount:1,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:1,disprovenCount:0,publicationEligibleCount:0; denialCounts=no-evidence:1,classifier-fail-closed:1,publication-ineligible:1; reasons=no-evidence,classifier-fail-closed,publication-ineligible; metadata=deliveryId:y,reviewOutputKey:y,correlationKey:y; redaction=privateOnly:y,candidateBodies:n,specialistProse:n,rawPrompts:n,rawModelOutput:n,diffs:n,evidencePayloads:n,rawFingerprints:n,publicationEvidence:n,unsafeFields:1

  • Review completed: 2026-05-18T05:19:40.049Z

  • Total wall-clock: 5m 54s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 827ms
    • retrieval/context assembly: 3.6s
    • executor handoff: 8.5s
    • remote runtime: 5m 36s
    • publication: 2.7s
  • Tokens: 130 in / 12,566 out | 0.4842

  • Keyword parsing: No keywords detected

AlwinEsch added 2 commits May 22, 2026 07:15
Relates to:
```
  CMake Deprecation Warning at CMakeLists.txt:2 (cmake_policy):
    Compatibility with CMake < 3.10 will be removed from a future version of
    CMake.
```
@AlwinEsch AlwinEsch changed the title update to visualization API 4.1.0 and code cleanups update to visualization API 5.0.0 and code cleanups May 22, 2026
@AlwinEsch
AlwinEsch merged commit 97ed5e9 into xbmc:Piers May 22, 2026
8 checks passed
@AlwinEsch
AlwinEsch deleted the Piers-change branch May 22, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant