nix: Fix segfaults in nix build with ClangTool compatibility patches#12
Open
randomizedcoder wants to merge 1 commit intoxdp2-dev:mainfrom
Open
nix: Fix segfaults in nix build with ClangTool compatibility patches#12randomizedcoder wants to merge 1 commit intoxdp2-dev:mainfrom
randomizedcoder wants to merge 1 commit intoxdp2-dev:mainfrom
Conversation
The nix build was crashing with segfaults due to differences in how
ClangTool API behaves in Nix environments vs traditional Linux distros.
Add patches to fix two issues:
- 01-nix-clang-system-includes.patch: ClangTool bypasses the Nix clang
wrapper, missing -isystem flags for headers. Adds include paths from
environment variables set by the Nix derivation.
- 02-tentative-definition-null-check.patch: C tentative definitions
(from XDP2_DECL_PROTO_TABLE macro) return hasInit()=true with void-type
InitListExpr on Nix clang 18.1.8+, causing null pointer crash when
getAs<RecordType>() returns nullptr. Adds null check to skip these.
Refactor the monolithic flake.nix (~1000 lines) into modular files:
- nix/packages.nix: Package definitions (nativeBuildInputs, buildInputs, devTools)
- nix/llvm.nix: LLVM/Clang configuration with wrapped llvm-config
- nix/env-vars.nix: Environment variable exports
- nix/devshell.nix: Development shell configuration
- nix/derivation.nix: Package derivation for nix build
- nix/shell-functions/: Modular shell functions (build, clean, configure, etc.)
Also:
- Upgrade from pinned LLVM 18 to default LLVM (21.1.8)
- Add BPF/XDP dev tools (bpftrace, bcc, perf, pahole, clang-tools)
- Update documentation with patch details and toolchain versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a refactor of the Nix, and adds some patches to Nix only to get it working. I tested this still builds on Ubuntu 24.04.
The nix build was crashing with segfaults due to differences in how ClangTool API behaves in Nix environments vs traditional Linux distros.
Add patches to fix two issues:
Refactor the monolithic flake.nix (~1000 lines) into modular files:
Also: