QE-746 As a QE member, I want to containerize Postgres Database clust…#38
QE-746 As a QE member, I want to containerize Postgres Database clust…#38egeaksoz-zz wants to merge 3 commits intomasterfrom
Conversation
…er for XLD testing, so I can include this platform at every release
# Conflicts: # src/main/kotlin/ai/digital/integration/server/common/domain/Cluster.kt # src/main/kotlin/ai/digital/integration/server/deploy/internals/cluster/DeployDockerClusterHelper.kt # src/main/kotlin/ai/digital/integration/server/deploy/tasks/StartDeployIntegrationServerTask.kt
| } | ||
|
|
||
| private fun getWorkerJdbcUrl(): String { | ||
| var workerJdbcUrl = "postgresql:5432/xld-db" |
There was a problem hiding this comment.
This is already not correct, as it depends what database is used, and this config has to be configurable.
| private fun getWorkerJdbcUrl(): String { | ||
| var workerJdbcUrl = "postgresql:5432/xld-db" | ||
| if (isDatabaseLoadBalancerEnabled()) { | ||
| workerJdbcUrl = "haproxydb:5000/postgres" |
There was a problem hiding this comment.
Same here, hard coded url is not acceptable.
|
|
||
| services: | ||
| zoo1: | ||
| image: zookeeper:3.4 |
| zoo1: | ||
| image: zookeeper:3.4 | ||
| hostname: zoo1 | ||
| container_name: zoo1 |
There was a problem hiding this comment.
Not the best names even for default value, and they should be also configurable
| hostname: zoo1 | ||
| container_name: zoo1 | ||
| ports: | ||
| - 2191:2181 |
There was a problem hiding this comment.
In all this file, all ports which are exposed have to be configurable.
| depends_on: | ||
| - zoo1 | ||
|
|
||
| zoo3: |
There was a problem hiding this comment.
The number of nodes and partitions have to be configurable.
I might want not 3 but 5 nodes.
Should be some simple way to specify it in config.
Like partitions: 5, and all this file is generated. Exposed ports have to be random, and the function used which identifies which port is free now. Check in the code, we have it.
| - XL_CLUSTER_MODE=default | ||
| - XL_DB_PASSWORD=admin | ||
| - XL_DB_USERNAME=postgres | ||
| - XL_DB_URL=jdbc:postgresql://haproxydb:5000/postgres |
| @@ -8,6 +8,7 @@ import org.gradle.kotlin.dsl.property | |||
| open class Cluster(objects: ObjectFactory) { | |||
There was a problem hiding this comment.
There is no documentation about it
There was a problem hiding this comment.
And please create a blog post for that to explain on the high level how it works.
2 participants
…er for XLD testing, so I can include this platform at every release