Draft
Conversation
andyhhp
reviewed
Feb 18, 2025
andyhhp
left a comment
andyhhp
left a comment
There was a problem hiding this comment.
I think you do want to split the mechanical fixes from the logical fixes (esp the lock contention one).
edwintorok
force-pushed
the
private/edvint/lockinglatency
branch
5 times, most recently
from
b96eb51 to
c2098f5
Compare
freddy77
reviewed
Feb 21, 2025
edwintorok
force-pushed
the
private/edvint/lockinglatency
branch
from
c2098f5 to
446f61e
Compare
Contributor
Author
Split into:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
edwintorok
force-pushed
the
private/edvint/lockinglatency
branch
from
446f61e to
447a64b
Compare
Reduce the scope of the global com mutex, otherwise every attempt to acquire a reader lock results in contention on this global mutex. Use a per-object-table lock instead. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/lockinglatency
branch
from
447a64b to
efa7b6f
Compare
TODO: use pthread_condattr_setclock and switch to a monotonic clock instead Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
private/edvint/lockinglatency
branch
from
efa7b6f to
c5777e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might need splitting into separate PRs (there are about 8 independent fixes here). For now keep them together until I test them.