feat(foxi): add LLAR formula - #128
Conversation
620b791 to
c09f397
Compare
There was a problem hiding this comment.
FennoAI Review
New LLAR recipe for houseroad/foxi. The overall structure is solid — commit pinning with a rationale comment, _llar_-prefixed scratch patch files, --forward --batch patch application, cache-hit-safe onTest flag derivation, and appropriate file permissions. Nice cross-platform touch setting both LD_LIBRARY_PATH and DYLD_LIBRARY_PATH.
One correctness issue is worth fixing (inline). The rest are consistency/documentation notes.
Consistency with existing recipes
- Filename: existing recipes use PascalCase (
Cglm_llar.gox,Jsonc_llar.gox,Zlib_llar.gox); this file is lowercasefoxi_llar.gox. Consider renaming toFoxi_llar.gox, and confirm recipe discovery does not depend on the capitalized name. - Indentation: this recipe uses 4-space indentation while all existing recipes use tabs (gofmt style). Consider converting to tabs.
versions.jsonuses 2-space indentation; siblings use tabs.
Documentation (relative to the well-commented cglm/json-c recipes)
- No comment explains the two patches (
fix-conflicting-types.patchalters the publiconnxInitGraph/onnxWaitEventForABI;cmake.patchchanges install layout) or theCMAKE_POLICY_VERSION_MINIMUM=3.5define. A short rationale for each would help future maintainers. - The
onTestflags are deliberately re-derived frominstallDirso the test works on a cache hit (onBuildskipped). The cglm/json-c recipes document this explicitly; a one-line comment here would match convention.
Minor
os.setenv "LD_LIBRARY_PATH"/"DYLD_LIBRARY_PATH"overwrite any inherited value rather than prependinginstallDir/lib:$LD_LIBRARY_PATH. Low impact since it runs only inonTest, but prepending is safer.
| int ret = onnxifi_load(ONNXIFI_LOADER_FLAG_VERSION_1_0, NULL, &onnx); | ||
| if (!ret) { | ||
| printf("Cannot load onnxifi lib\n"); | ||
| return 0; |
There was a problem hiding this comment.
The failure branch prints an error but returns 0 (success), so onTest (which checks the binary's exit code via lastErr!) can never fail even when onnxifi_load fails — the test becomes a no-op. onnxifi_load returns non-zero on success per upstream onnxifi_loader.h, so !ret is correctly the failure path; only the return code is wrong.
| return 0; | |
| if (!ret) { | |
| fprintf(stderr, "Cannot load onnxifi lib\n"); | |
| return 1; | |
| } |
Add an LLAR Formula for
houseroad/foxiat Conan source commitbd6feb6d0d3fc903df42b4feb82a602a5fcb1fd5.The implementation includes:
The upstream repository has no release tags, so the Formula uses the immutable Conan source commit explicitly and avoids inventing a version comparator.
Closes #110