go1.25 - #2346
Open
xushiwei wants to merge 2 commits into
Open
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review: bump Go compatibility lane to 1.25.0
This PR bumps the CI "compatibility" lane from Go 1.24.x to 1.25.0 (in goroot.yml, llgo.yml) and go.mod to go 1.25.0. The matrix substitutions are consistent and CI matrix sizing (job/shard counts) is unchanged. Security review found nothing — no new/unpinned actions, no secrets, 1.25.0 remains an exact reproducibility pin.
One real correctness bug and a few stale comments/docs remain from the incomplete rename:
Not inline (line outside the diff):
test/std/README.md:3— states compatibility tests run "across the pinned supported CI toolchains (Go 1.24 and Go 1.26)". The pinned compatibility toolchain is now Go 1.25, so this should read "Go 1.25 and Go 1.26". (Thego1.24build-tag references elsewhere in that README are about API availability and should stay.)
Additional findings
.github/workflows/goroot.yml:210: [P1] goroot summary still filters on 1.24.11 — compat rows break: Thesewrite_rowcalls were not updated with the matrix bump. The third positional arg is a version filter matched against column 2 of the summary TSV ($2 == version), which is now populated with1.25.0(fromGO_VERSION). Since no row has$2 == "1.24.11", both the Darwin and Linux compatibility rows will render0/4with all-zero stats, and the real 1.25.0 per-toolchain numbers are silently dropped (the**total**rows use an empty filter, so aggregates stay correct). The labels are also now misleading..github/workflows/goroot.yml:38: [P2] Stale comment: says Go 1.25 is omitted, but it is now the compat lane: This comment now contradicts the matrix directly above it:1.25.0is nowlane: compatibility(lines 30, 33-34). The claim that Go 1.25 is "intentionally omitted because it is not a compatibility target" is no longer true and is misleading. Please update to reflect that 1.25 is the current compatibility target..github/workflows/llgo.yml:25: [P2] Stale comment: 'Go 1.24 and 1.26 endpoints': The compatibility endpoint in the matrix below is now1.25.0, not 1.24. This comment should read "Go 1.25 and 1.26 endpoints"..github/workflows/llgo.yml:161: [P2] Stale comment: 'exercises Go 1.24 user-project/runtime': The demo/compatibility lane now uses1.25.0(the exclude just below referencesgo: "1.25.0"). This comment should say "Go 1.25".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.