fix: OpenCode follow-up restore and duplicate user message echoes#45
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix: OpenCode follow-up restore and duplicate user message echoes#45cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Follow-up persistence wrote Claude-format user JSONL that OpenCode's line processor ignored on DB replay, so prompts vanished after restart. Skip echoing plain-text user lines in reader_loop when Orbit already injected the same prompt (Claude stream-json). Co-authored-by: José Fernando <xinnaider@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The recent follow-up message persistence fix (#44) saved user prompts as Claude-compatible JSONL. OpenCode sessions still lost follow-up messages after restart because
process_line_opencodeignored alltype: userlines. Claude sessions could show duplicate follow-up messages when the CLI echoed the same plain-text user line that Orbit had already injected.Root cause
userline.reader_looppersisted and re-processed CLI echoes without checking whether the same plain-text user entry was already in the journal.Fix
push_injected_user_line).reader_loopwhen the journal already has the same prompt (tool_result user lines are unchanged).Validation
cargo test --lib(183 tests)cargo clippy -- -D warnings