fix: make for-loop control variables read-only compatible with Lua 5.5#52
Merged
xjdrew merged 1 commit intoxjdrew:masterfrom Apr 9, 2026
Merged
fix: make for-loop control variables read-only compatible with Lua 5.5#52xjdrew merged 1 commit intoxjdrew:masterfrom
xjdrew merged 1 commit intoxjdrew:masterfrom
Conversation
Lua 5.5 makes for-loop control variables read-only (const). Two files were assigning to control variables inside for-loop bodies: - levent/dns.lua: 'host = host:lower()' -> use local 'lhost' - levent/http/response.lua: 'f = util.canonical_header_key(f)' -> use local 'cf' These changes are backward compatible with Lua 5.4. Verified: - luac -p passes on both Lua 5.4.7 and Lua 5.5.0 - Compiles successfully with both Lua 5.4 and 5.5 headers - All tests pass on both versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua 5.5 makes for-loop control variables read-only (const). Two files were assigning to control variables inside for-loop bodies:
These changes are backward compatible with Lua 5.4.
Verified: