Skip to content

feat: enhance remote claim builder: implementation of remote payload claims and trust policy enforcement#353

Open
denopink wants to merge 6 commits intomainfrom
denopink/feat/remote-payload-claims
Open

feat: enhance remote claim builder: implementation of remote payload claims and trust policy enforcement#353
denopink wants to merge 6 commits intomainfrom
denopink/feat/remote-payload-claims

Conversation

@denopink
Copy link
Copy Markdown
Contributor

@denopink denopink commented Mar 27, 2026

  • introduce the ability to specify which claims from the remote claims endpoint you want to merge into your jwt claims set (ignoring remote claims that are not specify)
    • the default behavior - if not configured, then all of themis' claims can/will be overwritten by remote payload claims
  • introduce the ability to specify which policy is used to determine which turst related claims are sourced from between remote claims and themis.
    • default behavior - themis' trust related claims will always be overwritten by remote claims (if provided)
  • implement the actual remote payload claims and trust policy enforcement
  • tested this iteration of themis in cd and no regressions were observed in the acceptance or integration tests
  • update tests
  • update config example

…trust claim metadata

- introduces the ability to specify which policy is used to determine which turst related claims are sourced from between remote claims and themis.
   - default behavior - themis' trust related claims will always be overwritten by remote claims (if provided)
- update tests
- update config example
- enables the ability to specify which claims from the remote claims endpoint you want to merge into your jwt claims set (ignoring remote claims that are not specify)
   - the default behavior - if not configured, then all of themis' claims can/will be overwritten by remote payload claims
- update tests
- update config example
@denopink denopink requested a review from johnabass March 27, 2026 20:23
@denopink denopink self-assigned this Mar 27, 2026
@denopink denopink added the enhancement New feature or request label Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 83.67347% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.93%. Comparing base (a929880) to head (47200cd).

Files with missing lines Patch % Lines
token/claimBuilder.go 81.05% 18 Missing ⚠️
main.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   50.32%   52.93%   +2.61%     
==========================================
  Files          55       57       +2     
  Lines        2013     2146     +133     
==========================================
+ Hits         1013     1136     +123     
- Misses        964      977      +13     
+ Partials       36       33       -3     
Flag Coverage Δ
unittests 52.93% <83.67%> (+2.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…claims and trust policy enforcement

- implements the actual trust policy enforcement
- update tests
@denopink denopink force-pushed the denopink/feat/remote-payload-claims branch from bd7687c to de8c225 Compare March 27, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants