Skip to content

Add Intermediate-Context header support for Talaria message metadata#1160

Merged
denopink merged 7 commits intoxmidt-org:mainfrom
ChaitanyaSingla:intermediate-context-metadata
Apr 13, 2026
Merged

Add Intermediate-Context header support for Talaria message metadata#1160
denopink merged 7 commits intoxmidt-org:mainfrom
ChaitanyaSingla:intermediate-context-metadata

Conversation

@ChaitanyaSingla
Copy link
Copy Markdown
Contributor

This PR introduces the intermediate-context header as an optional field in the metadata preparation flow for both online and offline messages sent by Talaria.

Key Changes:

  1. Added support for intermediate-context header in message metadata construction.
  2. Updated relevant structs and interfaces to include the new header.

Purpose:
The intermediate-context header allows for carrying any extra information that may be required by the receiving systems.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.67%. Comparing base (75b7bf1) to head (921af14).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
device/mocks.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   81.79%   81.67%   -0.13%     
==========================================
  Files         150      150              
  Lines        7214     7220       +6     
==========================================
- Hits         5901     5897       -4     
- Misses       1124     1135      +11     
+ Partials      189      188       -1     
Flag Coverage Δ
unittests 81.67% <90.90%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made 1 change, updated the implementation to match device.newDevicecurrent options pattern for consistency

@denopink denopink merged commit c0fce4c into xmidt-org:main Apr 13, 2026
15 of 16 checks passed
@denopink
Copy link
Copy Markdown
Contributor

fyi releasing and then updating xmidt-org/talaria#558, if anything break then I'll patch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants