Adding dual ethernet 316 dev-kit#66
Merged
humphrey-xmos merged 2 commits intoxmos:developfrom Aug 19, 2025
Merged
Conversation
399cb74 to
09968f0
Compare
a6894ef to
58e0b87
Compare
d1951ec to
627416a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new dual ethernet XK-ETH-316-DUAL development kit, implementing only the first PHY (ETH0) for now. The changes include board configuration files, PHY driver implementation, and necessary updates to version numbers and documentation.
Key changes:
- Addition of XK-ETH-316-DUAL board support with single PHY implementation
- Debug unit additions for selective debug output across ethernet boards
- Version bump from 1.3.0 to 1.4.0 across all configuration files
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xn_files/xk-eth-316-dual.xn | New board configuration file defining ports and hardware layout for dual ethernet dev-kit |
| lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc | New PHY driver implementation for DP83825I PHYs with MMD register access |
| lib_board_support/api/boards/xk_eth_316_dual/board.h | New API header defining board-specific functions and constants |
| lib_board_support/src/boards/xk_eth_xu316_dual_100m/xk_eth_xu316_dual_100m.xc | Code improvements including debug units, magic number defines, and MMD register fixes |
| settings.yml, module_build_info, lib_build_info.cmake | Version updates from 1.3.0 to 1.4.0 |
| lib_board_support/api/boards/boards_utils.h | Board enumeration updates to include new XK_ETH_316_DUAL |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc
Outdated
Show resolved
Hide resolved
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc
Outdated
Show resolved
Hide resolved
627416a to
f935dcf
Compare
shuchitak
approved these changes
Aug 18, 2025
Contributor
shuchitak
left a comment
There was a problem hiding this comment.
Looks great! Hopefully we'll get more confidence that it works when we run lib_ethernet HW tests on this board.
lib_board_support/src/boards/xk_eth_316_dual/xk_eth_316_dual.xc
Outdated
Show resolved
Hide resolved
f935dcf to
b8c09f4
Compare
xross
reviewed
Aug 18, 2025
xross
reviewed
Aug 18, 2025
xross
reviewed
Aug 18, 2025
xross
reviewed
Aug 18, 2025
Adding debug units for selective output from this library
b8c09f4 to
fb95f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for new dual ethernet dev-kit. BUT, only first PHY for now. For reference these changes are built in lib_ethernet PR, xmos/lib_ethernet#182
Documentation update to follow this PR.
Please note, to complete port will need the following tasks to be completed on lib_ethernet,
Plus, updates to dual ethernet test board driver to fix issue of trying to access vendor specific register (0x302) without using MMD function. Added defines for magic numbers.
Also, added debug units to ethernet boards, for selective debug output.