Add all hosts MAC filter if IGMP enabled#71
Open
lhoward wants to merge 2 commits intoxmos:developfrom
Open
Conversation
Contributor
|
All tests are passing, but there are repo checks that are failing. Dates in files. Can you rebase onto latest develop, then it should be go to go. |
shim_{join,leave}_multicast_group assumed that LWIP_IGMP was enabled at build
time. If lwIP was built without it, return XTCP_EINVAL.
Signed-off-by: Luke Howard <lukeh@padl.com>
If IGMP is enabled, a MAC address filter for the all hosts multicast group must be added so that IGMP messages can be received from the IGMP querier. Fixes: xmos#70 Signed-off-by: Luke Howard <lukeh@padl.com>
humphrey-xmos
approved these changes
Mar 6, 2026
Contributor
humphrey-xmos
left a comment
humphrey-xmos
left a comment
There was a problem hiding this comment.
Nice simple update/ Thanks for catching the join multicast function isse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.