Open
Conversation
Contributor
ApprovabilityVerdict: Approved Backward-compatible protobuf schema additions (new enum, new fields, deprecations) for fork recovery functionality. Author is an admin who owns all changed files. Changes are additive with no breaking changes. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate a4c9c89
a4c9c89 to
bda091f
Compare
Dismissing prior approval to re-evaluate 16d3ffc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
MessageTypeenum andForkAdminChangemessage to MLS protocol for fork recoveryis_commitboolean inGroupMessage.V1andValidateGroupMessagesResponse.ValidationResponse, replacing it with amessage_typefield using a newMessageTypeenum that includesAPPLICATION,COMMIT, andFORK_ADMIN_CHANGEvalues.ForkAdminChangewire message in commit_log.proto with sequence ID, HMAC, signature, and group ID fields to support replay-protected fork admin operations.CommitLogEntryto carry a new installation credential signature (field 4) over the commit payload and group salt; the previous signature field is deprecated but retained for backward compatibility.GroupMessage.V1and validation responses should migrate fromis_committomessage_type; the deprecated fields remain on the wire but carry no new information.Macroscope summarized 16d3ffc.