Skip to content

Decentralized Fork Recovery Updates#325

Open
codabrink wants to merge 6 commits intomainfrom
coda/fork-admin
Open

Decentralized Fork Recovery Updates#325
codabrink wants to merge 6 commits intomainfrom
coda/fork-admin

Conversation

@codabrink
Copy link
Contributor

@codabrink codabrink commented Mar 10, 2026

Add MessageType enum and ForkAdminChange message to MLS protocol for fork recovery

  • Deprecates the is_commit boolean in GroupMessage.V1 and ValidateGroupMessagesResponse.ValidationResponse, replacing it with a message_type field using a new MessageType enum that includes APPLICATION, COMMIT, and FORK_ADMIN_CHANGE values.
  • Adds a new ForkAdminChange wire message in commit_log.proto with sequence ID, HMAC, signature, and group ID fields to support replay-protected fork admin operations.
  • Updates CommitLogEntry to carry a new installation credential signature (field 4) over the commit payload and group salt; the previous signature field is deprecated but retained for backward compatibility.
  • Behavioral Change: Consumers of GroupMessage.V1 and validation responses should migrate from is_commit to message_type; the deprecated fields remain on the wire but carry no new information.

Macroscope summarized 16d3ffc.

@codabrink codabrink requested a review from a team as a code owner March 10, 2026 18:01
@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Mar 10, 2026

Approvability

Verdict: Approved

Backward-compatible protobuf schema additions (new enum, new fields, deprecations) for fork recovery functionality. Author is an admin who owns all changed files. Changes are additive with no breaking changes.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Mar 10, 2026
@macroscopeapp macroscopeapp bot dismissed their stale review March 10, 2026 18:45

Dismissing prior approval to re-evaluate a4c9c89

macroscopeapp[bot]
macroscopeapp bot previously approved these changes Mar 10, 2026
@macroscopeapp macroscopeapp bot dismissed their stale review March 17, 2026 20:30

Dismissing prior approval to re-evaluate 16d3ffc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant