Skip to content

Reduce logging#556

Merged
fbac merged 1 commit intomainfrom
fbac/logging
Mar 24, 2026
Merged

Reduce logging#556
fbac merged 1 commit intomainfrom
fbac/logging

Conversation

@fbac
Copy link
Contributor

@fbac fbac commented Mar 24, 2026

Reduce log verbosity for rate limiting, subscriptions, and backfill workers

Downgrades several high-frequency log statements from Info to Debug across multiple packages to reduce noise in production logs.

  • In interceptor.go, rate-limited gRPC requests now log at Debug instead of Info.
  • In telemetry.go, ResourceExhausted and InvalidArgument errors now log at Debug; all other errors log at Error (previously Info).
  • In service.go, subscription start events for group and welcome messages now log at Debug.
  • In store.go and the backfiller workers, inbox log insertions, new member entries, and "nothing to process" states now log at Debug.
  • Behavioral Change: error-level logging is now used for most gRPC failures in the telemetry interceptor, which is an increase in severity for non-rate-limit errors.

Macroscope summarized 31e770e.

@fbac fbac requested a review from a team as a code owner March 24, 2026 14:52
macroscopeapp[bot]
macroscopeapp bot previously approved these changes Mar 24, 2026
@macroscopeapp
Copy link

macroscopeapp bot commented Mar 24, 2026

Approvability

Verdict: Approved

This PR only changes log levels from Info to Debug across multiple files to reduce log verbosity. The telemetry change also upgrades non-rate-limit errors to Error level. All changes are observability-only with no runtime behavior impact, and the author owns all modified files.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp bot dismissed their stale review March 24, 2026 14:58

Dismissing prior approval to re-evaluate 31e770e

@fbac fbac enabled auto-merge (squash) March 24, 2026 14:58
@fbac fbac merged commit 69543fd into main Mar 24, 2026
8 of 9 checks passed
@fbac fbac deleted the fbac/logging branch March 24, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants