Open
Conversation
bgoncharov
changed the title
evgenykochetkov
requested changes
Dec 18, 2018
Contributor
evgenykochetkov
left a comment
evgenykochetkov
left a comment
There was a problem hiding this comment.
Спасибо за проделанную работу! ❤️
Есть пара мелких замечаний:
Co-Authored-By: bgoncharov <bora4bora@gmail.com>
Co-Authored-By: bgoncharov <bora4bora@gmail.com>
nkrkv
requested changes
Dec 19, 2018
Member
nkrkv
left a comment
nkrkv
left a comment
There was a problem hiding this comment.
Thanks for the contribution ❤️
The headings nesting level has to be fixed (see below) and we’re ready to merge. If you also find a bit of time to translate C++ comments as well, that would be great (optional though).
|
|
||
| void evaluate(Context ctx) { | ||
| if (isInputDirty<input_SET>(ctx)) { | ||
| // Get T-input value. Conventionally it should be expressed in seconds |
Member
There was a problem hiding this comment.
Comments in C++ are part of the article content. I won’t block the PR because of untranslated comments, but nevertheless, it would be fine.
Co-Authored-By: bgoncharov <bora4bora@gmail.com>
Co-Authored-By: bgoncharov <bora4bora@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RU.md for xod-docs/docs/guide/cpp-time/