Add a signing threshold to the coordinators#177
Merged
Conversation
setzeus
reviewed
Jun 23, 2025
…ect number of nonces and signature shares when it is set
xoloki
force-pushed
the
signing-threshold
branch
from
ac1f21a to
f1b9233
Compare
xoloki
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FIREcoordinator currently waits to get a number of nonces from signers who control athresholdnumber of keys before continuing a signing round. While this is optimal for normal use, there are scenarios when we want to wait for more signers to respond, e.g. insBTCwhen we are verifying that all signers have completed DKG successfully, and can form a valid spend transaction from the new aggregate key.This PR adds a config field
sign_threshold, and by default sets it tothreshold. TheFIREcoordinator then waits to get nonces from signers who control this many keys before continuing. Asign_threshold_signtest has been added to validate this new behavior.Since we added this to
state_machine::coordinator::Config, I went ahead and updated theFROSTcoordinator to also respect this field. Previously theFROSTcoordinator had waited for all signers to sign, ignoring the configuredthreshold.Fixes #174