Add SubFileSystem constructor argument for ordinal compare choices#106
Merged
Conversation
joshuascript
changed the title
xoofx
reviewed
Jun 4, 2026
Owner
|
Thanks! |
Contributor
Author
|
Nice working with you. Much appreciated. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #105
Kind of new to submitting PRs but I tried my best to stage this well (emerging college student).
Add a SubFileSystem overload to allow ordinal compare to be chosen without needing an inherited class.
That way I can do
new SubFileSystem( system, path, StringComparison.OrdinalIgnoreCase, false )instead ofoverriding ConvertPathFromDelegate.
I also created an overload for
UPathExtensions.IsInDirectoryso that the decided ordinal can resolve the same way,otherwise when a path is checked in a given directory it may return false even if
ConvertPathFromDelegateis true.FileSystemWatcher's
ShouldRaiseEventImplreturns args.FullPath.IsInDirectory(Path, IncludeSubdirectories), by default, so I included a small override that is the same thing but with the ordinal choice.I added new tests for to make sure ordinal still works by default and can be overriden to use the new string compare. There is also a skipped test for FilterPattern because that also is case-insensitive by default when comparing globs, but that's a separate PR for a separate day.
Am I headed in the right direction?