Removed explicit setting of brackets for ngChange attribute#57
Open
Tyrion85 wants to merge 1 commit intoxpepermint:masterfrom
Open
Removed explicit setting of brackets for ngChange attribute#57Tyrion85 wants to merge 1 commit intoxpepermint:masterfrom
Tyrion85 wants to merge 1 commit intoxpepermint:masterfrom
Conversation
…uld be backward compatibile - for settings without brackets, they should still be inserted automatically. This solves the issue xpepermint#10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed explicit setting of brackets for ngChange attribute. Code should be backward compatibile - for settings without brackets, they should still be inserted automatically. This solves the issue #10
In my (limited) findings, it seems like the issue occurs on Angular < 1.3. After this fix, code works on 1.2.x.