feat(#564): collapse completed milestone groups in dependency graph - #664
Conversation
|
Warning Review limit reached
Next review available in: 24 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a085234 to
26c23e5
Compare
|



Summary
extra="ignore"overrides and unused fieldsChanges
Supervisor dependency graph (the #564 feature)
Feature removal: merge queue monitor
merge_queue_monitor.pyservice,MergeQueueEntryDB model, migration 029, and 1285 lines of tests_wait_and_finalize,recover_stale_runs, and dashboard lifespan startupintegrate-pr.mdcommandFeature removal: direct subprocess spawn
spawn_direct()and_PIPELINE_ROLESfromsova/ipc/runtime.pystart_agent()now routes all roles throughClaudeCodeRuntime.spawn()uniformlyFeature removal: issue state rollback
rollback_issue_state()fromagent_recovery.pyand its invocation inrecover_stale_runsRESET_STALE_STATEandSPAWN_TRIAGEprogression actions,_execute_stale_reset(), and associated gate checks from the progression enginetest_rollback.py(263 lines)Feature removal: config hot-reload
reload_config(),_config_reloadedevent, and_interruptible_sleep()fromSupervisorDaemon_reload_daemon_config()from settings routerself._configdirectly and computes poll interval once at loop startConfig model cleanup
extra="ignore"from all PydanticSettingsConfigDictacross 30+ config models (reverts to default Pydantic behavior)supervisor.auto_triage,dashboard.confirm_model,task_source.jira_display_namefields and their settings metadataMisc cleanup
_resolve_issue_worktreein agent_context.pyRearrangeCommitsStep.validate_outputby removing agent-memory exclusion from diff checks_queueSaveInFlight/_queueLastSavedrace guard and simplified drag-drop in supervisor queue JS_get_project_agentsregistry fallback for non-default slugssova.toml: poll_interval 240s to 30s, scheduler disabled, removed auto_research/auto_triageReview guidance
This PR bundles the requested graph collapse feature (#564) with significant dead code removal. The removals are the bulk of the diff (3,376 of 3,788 deleted lines).
Key areas to verify:
supervisor.htmlare the core feature. Check that tombstone rendering, expand/collapse state, and the "Hide Done" toggle interact correctlymerge_queue_monitororMergeQueueEntryextra="ignore"removal: this changes Pydantic validation from silently ignoring unknown TOML keys to raising errors. Any project with typos or deprecated keys insova.tomlwill now fail at config loadspawn_directremoval: all agent spawning now goes through Claude Code. This re-introduces the wrapper cost (~$0.50/run) and 600s timeout thatspawn_directwas designed to avoidpoll_interval_secondsdropped from 240 to 30,scheduler_enabledset to false,auto_researchremoved. These are local config changes that should not shipTest plan
make checkpasses (lint + full pytest suite)test_merge_queue_monitor.py,test_rollback.py, and related test functions intest_dashboard.py,test_progression.py,test_config.py,test_ipc.py,test_agent_pool.pyCloses #564