Skip to content

fix: avoid atan branch cut in complex trigonometric test (musl CI) #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serge-sans-paille merged 1 commit into from
Apr 29, 2026
+5 −1
Merged

fix: avoid atan branch cut in complex trigonometric test (musl CI) #1336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/test_complex_trigonometric.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ struct complex_trigonometric_test
real_value_type(0.1) + i * real_value_type(56.) / nb_input);
ainput[i] = value_type(real_value_type(-1.) + real_value_type(2.) * i / nb_input,
real_value_type(-1.1) + real_value_type(2.1) * i / nb_input);
atan_input[i] = value_type(real_value_type(-10.) + i * real_value_type(20.) / nb_input,
// Avoid sampling the branch cut of complex atan at (Re=0, |Im|>=1):
// the sign of Re(catan(+/-0 + i*y)) for |y|>1 is implementation-defined
// (C99 7.3.4.1), and glibc and musl disagree there. Starting Re at -9.5
// makes Re=0 occur at i=19/40 of the range, where |Im|<1 (analytic).
atan_input[i] = value_type(real_value_type(-9.5) + i * real_value_type(20.) / nb_input,
real_value_type(-9.) + i * real_value_type(21.) / nb_input);
}
expected.resize(nb_input);
Expand Down
Loading