Uniform header inclusion#1343
Conversation
|
That's cool, but you also need to write some rule to ensure we don't regress on those, otherwise we're going to repeatedly hit this. I think I prefer having standard header include last, as a way to detect some missing includes hidden by transitive inclusion. This can be enforced by the following clang-format option: |
|
@serge-sans-paille this should be good now, though slightly larger. |
|
I recently also added support for clang-tidy include what you use: flatironinstitute/finufft@67f0e7c What so you think about incorporating it here? If this is noise, feel free to discard the suggestion :-) |
| #ifdef XSIMD_ENABLE_XTL_COMPLEX | ||
| template <typename T, bool i3ec, size_t N> | ||
| struct has_simd_register<xtl::complex<T, T, i3ec>, emulated<N>> : std::true_type | ||
| struct has_simd_register<xtl::xcomplex<T, T, i3ec>, emulated<N>> : std::true_type |
There was a problem hiding this comment.
how did we miss that one?
There was a problem hiding this comment.
Indeed ! That why maybe randomized CI settings might be helpful to explore the combinatorial mix of settings. It could be done in a CRON job.
serge-sans-paille
left a comment
There was a problem hiding this comment.
I'm very happy with the automation of that task \o/
@DiamonDinoia I also very much want to have this in xsimd, but I am logging out for the next couple days. I'll merge this one so that it does not get outdated. Feel free to send a PR if mine does not come soon enough :) |
No worries! I am about to logout for ~2 weeks :) |
No description provided.