Add efficient_bmi2 cpu feature#1354
Merged
Merged
Conversation
| auto ext_model = leaf1().get_range<eax::ext_model_start, eax::ext_model_end>(); | ||
| auto family_id = leaf1().get_range<eax::family_id_start, eax::family_id_end>(); | ||
| return (family_id == 15 || family_id == 6) ? ((ext_model << 4) + model) : model; | ||
| } |
Contributor
There was a problem hiding this comment.
it would be great to add some testing for those.
I wonder if we could compare to the output of __builtin_cpu_is and __builtin_cpu_supports as a sanity check?
Contributor
There was a problem hiding this comment.
(can be in a follow-up)
Contributor
|
LGTM |
Contributor
|
btw: thanks for quoting the wikipedia page, it helped a lot for the review |
Contributor
Author
|
I think a good approach would be an optional executable that spit it all out as text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.