Support For One Object, Multiple Templates#18
Open
heroinbob wants to merge 6 commits into
Open
Conversation
…s many passbook pass types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a project that requires several looks for a pass based on various criteria. Maintaining several pass type ids, configurations and classes ends up being time consuming and bloated. This allows the object to determine what pass template to use based on the pass_type_id attribute value rather than the class name. I also added some test coverage to ensure backwards compatibility, and updated the README.md.
I thought this might be a useful feature for others too.