feat: accept max reasoning effort - #1
Open
jonathangtecom wants to merge 1 commit into
Open
Conversation
Codex's own model cache lists `max` as a supported reasoning level for the
gpt-5.6 family:
gpt-5.6-luna → low · medium · high · xhigh · max
("Maximum reasoning depth for the hardest problems")
`reasoningEfforts` stopped at `xhigh`, so `advanced.reasoning: "max"` was
rejected by the schema before Codex ever saw it:
Invalid enum value. Expected 'minimal' | 'low' | 'medium' | 'high' | 'xhigh',
received 'max'
The CLI accepts it, so the level was reachable with `codex exec` directly but
not through this server.
One constant feeds every schema, so the change is the enum plus the four
descriptions that named `xhigh` as the ceiling. `dist/index.js` rebuilt so
`check:dist` stays clean. Existing behaviour is unchanged — `max` is opt-in and
`minimal` is still rejected for the documented web_search reason.
Verified with `npm run build` (tsc clean) and `npm test` — 19 files, 142 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
maxto the accepted reasoning efforts.Why
Codex's own model cache lists
maxas a supported reasoning level for the gpt-5.6 family:reasoningEffortsinsrc/runner.tsstopped atxhigh, so the request was rejected by the schema before Codex ever saw it:The CLI accepts
max, so the level was reachable withcodex execdirectly but not through this server.I hit this driving several long-running
gpt-5.6-lunapatch agents where the deepest reasoning level was genuinely wanted.Change
One constant feeds every schema, so the diff is the enum plus the four descriptions that named
xhighas the ceiling:src/runner.ts—reasoningEffortsgainsmaxsrc/schemas.ts— three descriptions updatedsrc/index.ts— the guidance line updateddist/index.js— rebuilt socheck:diststays cleanBehaviour is otherwise unchanged:
maxis opt-in, andminimalis still rejected for the documented web_search reason.Verification
npm run build—tsc --noEmitcleannpm test— 19 files, 142 tests passingadvanced: {model: "gpt-5.6-luna", reasoning: "max"}was rejected before this change and starts a session after it.Happy to adjust the wording of the descriptions if you'd rather steer callers away from
maxmore strongly thanxhigh.