Merged
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiedeziel and the rest of your teammates on |
|
Visit the preview URL for this PR (updated for commit c724090): https://gcode-preview--pr229-10-16-remove-the-cod-c3ji4tzq.web.app (expires Fri, 15 Nov 2024 05:25:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
11 tasks
Member
|
nice an DRY! we could now generate the methods for |
sophiedeziel
added a commit
that referenced
this pull request
Oct 19, 2024
sophiedeziel
added a commit
that referenced
this pull request
Oct 19, 2024
sophiedeziel
added a commit
that referenced
this pull request
Oct 19, 2024
* Remove the code enum (#229) * Bring back a representation of layers * No need to expose isPlanar now * Make layers 100% progressive rendering ready * Layer number, height and z * fix the splitting logic
sophiedeziel
added a commit
that referenced
this pull request
Oct 24, 2024
sophiedeziel
added a commit
that referenced
this pull request
Oct 24, 2024
* Remove the code enum (#229) * Bring back a representation of layers * No need to expose isPlanar now * Make layers 100% progressive rendering ready * Layer number, height and z * fix the splitting logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #211
The
Codeenum bothered me a lot. I figured how to make the interpreter work with a magic function without having to use an enum. I think Typescript did not complain in the previous implementation because enum values are the same type or subtype of the index method. I had to add an index signature to make it work with strings.Now, to define a new gcode implementation there's only one file to touch (excluding tests). We only have to define the new method!