POC: toggle extrusions and travel moves without re-rendering everyting#311
Draft
sophiedeziel wants to merge 2 commits intomanage_renders_and_eventsfrom
Draft
POC: toggle extrusions and travel moves without re-rendering everyting#311sophiedeziel wants to merge 2 commits intomanage_renders_and_eventsfrom
sophiedeziel wants to merge 2 commits intomanage_renders_and_eventsfrom
Conversation
sophiedeziel
force-pushed
the
objects_manager
branch
from
2a97b8c to
de7cfa8
Compare
Tests cover event registration/emission, visibility toggles, rendering methods, disposal, and clipping plane updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #282
I extracted an object manager. That god class we had was reduced to demigod in #309 and now it's just a nice and reasonable class! sub 900 lines and next commits will reduce it even more!
What that manager does is to keep track of the meshes, materials and stuff. When it's time to dispose of them, it disposes of them. When we just want to hide them or render them again, we don't need to re-calculate everything from scratch.
WIP