Skip to content

#374 asynch, alembic compatibility#375

Draft
mayty wants to merge 1 commit intoxzkostyan:masterfrom
mayty:bugfix/374_asynch_compatibility
Draft

#374 asynch, alembic compatibility#375
mayty wants to merge 1 commit intoxzkostyan:masterfrom
mayty:bugfix/374_asynch_compatibility

Conversation

@mayty
Copy link
Copy Markdown

@mayty mayty commented May 15, 2025

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

@mayty
Copy link
Copy Markdown
Author

mayty commented May 15, 2025

@xzkostyan Hi, could you take a look at this PR?

Comment thread setup.py
'requests',
'clickhouse-driver>=0.1.2',
'asynch>=0.2.2,<=0.2.4',
'asynch>=0.2.2,<0.4.0',
Copy link
Copy Markdown

@stankudrow stankudrow May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.

The version v0.2.4 and v0.2.5 are advisable to be excluded: the v0.2.4 might have (if I am not mistaken) and the v0.2.5 has issues with connection management handling logic (an example).

The v0.3.0 seems to be OK except some bugs that are currently under the progress (consider having a look at this PR) and a minor improvement here.

Copy link
Copy Markdown

@stankudrow stankudrow May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may do:

Suggested change
'asynch>=0.2.2,<0.4.0',
'asynch>=0.2.2,!=0.2.4,!=0.2.5,<0.4.0',

https://packaging.python.org/en/latest/specifications/version-specifiers/#id5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken import due to Alembic removed _reflect_table Compatibility issue with asynch==0.3.0

2 participants