#374 asynch, alembic compatibility#375
Draft
mayty wants to merge 1 commit intoxzkostyan:masterfrom
Draft
Conversation
Author
|
@xzkostyan Hi, could you take a look at this PR? |
stankudrow
reviewed
May 29, 2025
| 'requests', | ||
| 'clickhouse-driver>=0.1.2', | ||
| 'asynch>=0.2.2,<=0.2.4', | ||
| 'asynch>=0.2.2,<0.4.0', |
There was a problem hiding this comment.
Hello.
The version v0.2.4 and v0.2.5 are advisable to be excluded: the v0.2.4 might have (if I am not mistaken) and the v0.2.5 has issues with connection management handling logic (an example).
The v0.3.0 seems to be OK except some bugs that are currently under the progress (consider having a look at this PR) and a minor improvement here.
There was a problem hiding this comment.
This may do:
Suggested change
| 'asynch>=0.2.2,<0.4.0', | |
| 'asynch>=0.2.2,!=0.2.4,!=0.2.5,<0.4.0', |
https://packaging.python.org/en/latest/specifications/version-specifiers/#id5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
flake8and fix issues.pytestno tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.