-
Notifications
You must be signed in to change notification settings - Fork 29
Sprint_4 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iermonakhovagalina
wants to merge
4
commits into
yandex-praktikum:main
Choose a base branch
from
iermonakhovagalina:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sprint_4 #16
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Python | ||
| __pycache__/ | ||
| *.pyc | ||
| *.pyo | ||
| *.pyd | ||
| *.env | ||
| *.venv | ||
|
|
||
| # VS Code | ||
| .vscode/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,21 @@ | ||
| # qa_python | ||
| # Sprint_4 | ||
| # BooksCollector – Автотесты на pytest | ||
|
|
||
| ## О проекте | ||
| Тестируем класс BooksCollector, который позволяет: | ||
|
|
||
| - Добавлять книги и присваивать им жанры. | ||
| - Получать книги по жанру или подходящие детям. | ||
| - Управлять списком избранного. | ||
|
|
||
| ## Покрытые тесты | ||
| - Добавление книг (валидные и невалидные названия). | ||
| - Установка жанра книги (валидный и невалидный жанр). | ||
| - Получение книг по жанру. | ||
| - Книги для детей (без возрастного ограничения). | ||
| - Избранные книги: добавление, удаление, проверка на дубликаты. | ||
|
|
||
| ## Запуск тестов | ||
| ```bash | ||
| pip install pytest | ||
| pytest -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,80 @@ | ||
| import pytest | ||
| from main import BooksCollector | ||
|
|
||
| # класс TestBooksCollector объединяет набор тестов, которыми мы покрываем наше приложение BooksCollector | ||
| # обязательно указывать префикс Test | ||
|
|
||
| @pytest.fixture | ||
| def collector(): | ||
| return BooksCollector() | ||
|
|
||
|
|
||
| class TestBooksCollector: | ||
|
|
||
| # пример теста: | ||
| # обязательно указывать префикс test_ | ||
| # дальше идет название метода, который тестируем add_new_book_ | ||
| # затем, что тестируем add_two_books - добавление двух книг | ||
| def test_add_new_book_add_two_books(self): | ||
| # создаем экземпляр (объект) класса BooksCollector | ||
| collector = BooksCollector() | ||
| def test_add_new_book_add_two_books(self, collector): | ||
| collector.add_new_book('Вокруг света за 80 дней') | ||
| collector.add_new_book('Десять негритят') | ||
| assert len(collector.get_books_genre()) == 2 | ||
|
|
||
| @pytest.mark.parametrize("name", ["", "A" * 41]) | ||
| def test_add_new_book_invalid_name(self, collector, name): | ||
| collector.add_new_book(name) | ||
| assert name not in collector.get_books_genre() | ||
|
|
||
| def test_set_book_genre_success(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.set_book_genre("Вокруг света за 80 дней", "Приключения") | ||
| assert collector.get_books_genre()["Вокруг света за 80 дней"] == "Приключения" | ||
|
|
||
| def test_get_book_genre(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.set_book_genre("Вокруг света за 80 дней", "Приключения") | ||
| assert collector.get_book_genre("Вокруг света за 80 дней") == "Приключения" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Нужно исправить: для get_book_genre должен быть отдельный тест. Тесты не должны дублировать друг друга. В идеале - чтобы в каждом тесте использовался только один проверяемый метод, все остальное можно получить прямым доступом к словарям и спискам |
||
|
|
||
| def test_set_book_genre_invalid_genre(self, collector): | ||
| collector.add_new_book("Книга") | ||
| collector.set_book_genre("Книга", "Неизвестный жанр") | ||
| assert collector.get_book_genre("Книга") == "" | ||
|
|
||
| def test_get_books_with_specific_genre(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.set_book_genre("Вокруг света за 80 дней", "Приключения") | ||
| collector.add_new_book("Десять негритят") | ||
| collector.set_book_genre("Десять негритят", "Детективы") | ||
| assert collector.get_books_with_specific_genre("Приключения") == ["Вокруг света за 80 дней"] | ||
|
|
||
| def test_get_books_for_children(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.set_book_genre("Вокруг света за 80 дней", "Приключения") | ||
| collector.add_new_book("Десять негритят") | ||
| collector.set_book_genre("Десять негритят", "Детективы") | ||
| assert collector.get_books_for_children() == ["Вокруг света за 80 дней"] | ||
|
|
||
| def test_add_book_in_favorites_success(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.add_book_in_favorites("Вокруг света за 80 дней") | ||
| assert "Вокруг света за 80 дней" in collector.favorites | ||
|
|
||
| def test_get_list_of_favorites_books(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.add_book_in_favorites("Вокруг света за 80 дней") | ||
| assert collector.get_list_of_favorites_books() == ["Вокруг света за 80 дней"] | ||
|
|
||
| # добавляем две книги | ||
| collector.add_new_book('Гордость и предубеждение и зомби') | ||
| collector.add_new_book('Что делать, если ваш кот хочет вас убить') | ||
| def test_add_book_in_favorites_no_duplicates(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.add_book_in_favorites("Вокруг света за 80 дней") | ||
| collector.add_book_in_favorites("Вокруг света за 80 дней") | ||
| assert collector.get_list_of_favorites_books().count("Вокруг света за 80 дней") == 1 | ||
|
|
||
| # проверяем, что добавилось именно две | ||
| # словарь books_rating, который нам возвращает метод get_books_rating, имеет длину 2 | ||
| assert len(collector.get_books_rating()) == 2 | ||
| def test_delete_book_from_favorites(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.add_book_in_favorites("Вокруг света за 80 дней") | ||
| collector.delete_book_from_favorites("Вокруг света за 80 дней") | ||
| assert "Вокруг света за 80 дней" not in collector.get_list_of_favorites_books() | ||
|
|
||
| # напиши свои тесты ниже | ||
| # чтобы тесты были независимыми в каждом из них создавай отдельный экземпляр класса BooksCollector() | ||
| def test_get_books_genre_returns_dict(self, collector): | ||
| collector.add_new_book("Вокруг света за 80 дней") | ||
| collector.add_new_book("Десять негритят") | ||
| expected = { | ||
| "Вокруг света за 80 дней": "", | ||
| "Десять негритят": "" | ||
| } | ||
| assert collector.get_books_genre() == expected | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно исправить: для get_books_genre тоже нужна отдельная проверка