Optimistic error handling in IRProcessor#16
Open
konovalov-aleks wants to merge 1 commit into
Open
Conversation
Previously, IRProcessor built error messages even when validation succeeded. With this patch, message parts are passed to Ensure separately and combined only on failure, avoiding unnecessary allocations, string concatenations, and integer conversions on the successful path. Tests have been added to cover IRProcessor validation errors and their diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that IRProcessor builds error messages every time even when validation succeeds. This simple patch introduces a small compiler optimization: message parts are passed to Ensure separately and combined only on failure, avoiding unnecessary allocations, string concatenations, and integer conversions on the successful path.
I also added tests covering IRProcessor validation errors and their diagnostics.
Thank you for the great project!