Fix FullSegment skipping the rune after a null dict match#214
Merged
Fix FullSegment skipping the rune after a null dict match#214
Conversation
Co-authored-by: yanyiwu <2162645+yanyiwu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FullSegment cut issue when du is nullptr
Fix FullSegment skipping the rune after a null dict match
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FullSegment::Cutcould advancemaxIdxwith a stalewordLenwhen a DAG edge haddu == NULL. In inputs like崎岖的牙齿, that caused the segmenter to skip的after encountering an unknown rune.Root cause
wordLenwas only updated on dictionary hits.du == NULL, the previous matched word length leaked into the nextmaxIdxcalculation.Change
wordLento1for null dictionary-unit edges so unknown runes advance by a single rune instead of reusing the prior match length.Regression coverage
FullSegmenttest for崎岖的牙齿.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.