Skip to content

Fix: deploy artifact id type error #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanyongyu merged 1 commit into from
May 1, 2026
Merged

Fix: deploy artifact id type error #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions codegen/parser/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ def merge_list(source: "Source", new: list | dict):
def merge_inplace(source: "Source", new: Any):
if isinstance(new, dict):
_handle_copy(source, new)
if not new:
return

if isinstance(source.data, dict) and isinstance(new, dict):
merge_dict(source, new)
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/ghec_v2022_11_28/models/group_1440.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ReposOwnerRepoPagesDeploymentsPostBody(GitHubModel):
The object used to create GitHub Pages deployment
"""

artifact_id: Missing[float] = Field(
artifact_id: Missing[int] = Field(
default=UNSET,
description="The ID of an artifact that contains the .zip or .tar of static assets to deploy. The artifact belongs to the repository. Either `artifact_id` or `artifact_url` are required.",
)
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/ghec_v2022_11_28/rest/repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17394,7 +17394,7 @@ def create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down Expand Up @@ -17476,7 +17476,7 @@ async def async_create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/ghec_v2022_11_28/types/group_1440.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyType(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand All @@ -31,7 +31,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyTypeForResponse(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/ghec_v2026_03_10/models/group_1437.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ReposOwnerRepoPagesDeploymentsPostBody(GitHubModel):
The object used to create GitHub Pages deployment
"""

artifact_id: Missing[float] = Field(
artifact_id: Missing[int] = Field(
default=UNSET,
description="The ID of an artifact that contains the .zip or .tar of static assets to deploy. The artifact belongs to the repository. Either `artifact_id` or `artifact_url` are required.",
)
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/ghec_v2026_03_10/rest/repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17396,7 +17396,7 @@ def create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down Expand Up @@ -17478,7 +17478,7 @@ async def async_create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/ghec_v2026_03_10/types/group_1437.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyType(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand All @@ -31,7 +31,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyTypeForResponse(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/v2022_11_28/models/group_1264.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ReposOwnerRepoPagesDeploymentsPostBody(GitHubModel):
The object used to create GitHub Pages deployment
"""

artifact_id: Missing[float] = Field(
artifact_id: Missing[int] = Field(
default=UNSET,
description="The ID of an artifact that contains the .zip or .tar of static assets to deploy. The artifact belongs to the repository. Either `artifact_id` or `artifact_url` are required.",
)
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/v2022_11_28/rest/repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16420,7 +16420,7 @@ def create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down Expand Up @@ -16502,7 +16502,7 @@ async def async_create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/v2022_11_28/types/group_1264.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyType(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand All @@ -31,7 +31,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyTypeForResponse(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/v2026_03_10/models/group_1263.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ReposOwnerRepoPagesDeploymentsPostBody(GitHubModel):
The object used to create GitHub Pages deployment
"""

artifact_id: Missing[float] = Field(
artifact_id: Missing[int] = Field(
default=UNSET,
description="The ID of an artifact that contains the .zip or .tar of static assets to deploy. The artifact belongs to the repository. Either `artifact_id` or `artifact_url` are required.",
)
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/v2026_03_10/rest/repos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16422,7 +16422,7 @@ def create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down Expand Up @@ -16504,7 +16504,7 @@ async def async_create_pages_deployment(
data: UnsetType = UNSET,
headers: Optional[Mapping[str, str]] = None,
stream: bool = False,
artifact_id: Missing[float] = UNSET,
artifact_id: Missing[int] = UNSET,
artifact_url: Missing[str] = UNSET,
environment: Missing[str] = UNSET,
pages_build_version: str = "GITHUB_SHA",
Expand Down
4 changes: 2 additions & 2 deletions githubkit/versions/v2026_03_10/types/group_1263.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyType(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand All @@ -31,7 +31,7 @@ class ReposOwnerRepoPagesDeploymentsPostBodyTypeForResponse(TypedDict):
The object used to create GitHub Pages deployment
"""

artifact_id: NotRequired[float]
artifact_id: NotRequired[int]
artifact_url: NotRequired[str]
environment: NotRequired[str]
pages_build_version: str
Expand Down
1 change: 1 addition & 0 deletions githubkit/versions/versions.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ source = "https://raw.githubusercontent.com/github/rest-api-description/d3a3c2a5
"/components/schemas/team-organization/properties/name" = {type = ["string", "null"]}
"/components/schemas/team-organization/properties/blog" = {type = ["string", "null"]}
"/components/schemas/pages-deployment-status/properties/status/enum" = {"<add>" = ["deployment_queued"]}
"/paths/~1repos~1{owner}~1{repo}~1pages~1deployments/post/requestBody/content/application~1json/schema/properties/artifact_id/type" = {"<copy>" = "#/components/parameters/artifact-id/schema/type"}
"/components/schemas/git-user/properties/date" = {format = "date-time"}
"/components/schemas/verification/required" = {"<remove>" = ["verified_at"]}
"/components/schemas/diff-entry/properties/blob_url" = {type = ["string", "null"]}
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,9 @@ source = "descriptions-next/ghec/ghec.2026-03-10.json"
"deployment_queued",
] }

# https://github.com/yanyongyu/githubkit/issues/300
"/paths/~1repos~1{owner}~1{repo}~1pages~1deployments/post/requestBody/content/application~1json/schema/properties/artifact_id/type" = { "<copy>" = "#/components/parameters/artifact-id/schema/type" }

# https://github.com/yanyongyu/githubkit/issues/199
# https://github.com/github/rest-api-description/issues/4697
# git user date format should be date-time
Expand Down
Loading