Fix static file caching for Development hot reload and CDN no-transform #11 - #12
Closed
yasmoradi wants to merge 1 commit into
Closed
Fix static file caching for Development hot reload and CDN no-transform #11#12yasmoradi wants to merge 1 commit into
yasmoradi wants to merge 1 commit into
Conversation
yasmoradi
added
bug
Owner
Author
|
Superseded: opened on upstream as bitfoundation#12764. This fork PR was created by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks static-file caching into a middleware using
Response.OnStarting, addsno-cachein Development, and keepsNoTransformfor versioned production assets.Cache-Control: no-cache, which fixes SCSS changes sometimes not applying under Hot Reload /dotnet watch.Public+NoTransform+max-agefor versioned (?v=) assets.NoTransformprevents CDNs from re-compressing the already highly-compressed Blazor publish output, reducing the size served behind the CDN.Changes
Program.Middlewares: replaceUseStaticFiles(OnPrepareResponse = ...)with a middleware that setsCache-ControlonResponse.OnStarting(no-cache in Development;Public+NoTransform+max-agefor versioned assets in production), followed byUseStaticFiles().wwwroot/_framework/.gitkeepto the Windows client so the folder is tracked (also helpsdotnet watch).Related Issue
This closes #11