ADR: gate consequential connector writes at the effect, not the command string - #561
Open
brAperia2025 wants to merge 1 commit into
Open
ADR: gate consequential connector writes at the effect, not the command string#561brAperia2025 wants to merge 1 commit into
brAperia2025 wants to merge 1 commit into
Conversation
…nd string Informal ADR: close two already-documented limitations (command policy bypassable; sandbox credentials ambient) for consequential external writes by routing such connectors through the credential broker and requiring an action-bound single-use approval at the broker. Discussion doc; no code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An informal discussion ADR (per CONTRIBUTING).
SECURITY.md already documents two limitations — command policy is bypassable, and sandbox credentials are ambient while in use. This proposes closing both for the case that matters most, consequential external writes made by a connector, by gating the effect (the outbound write) rather than the command string that produces it:
Full write-up in the added
adrs/file. No code — happy to implement if the shape sounds right.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.