feat(slack): org admin setting + emoji picker for ack emoji - #571
Open
16francej wants to merge 6 commits into
Open
feat(slack): org admin setting + emoji picker for ack emoji#57116francej wants to merge 6 commits into
16francej wants to merge 6 commits into
Conversation
…EMOJI An org-layer env knob (comma/space-separated Slack short-names, colons optional, e.g. "mirai_thinking, mirai_ok") that fully replaces the stock curated/default candidates for both the quick fallback reaction and the model-picked ack emoji. Unset or empty keeps today's behavior. Verified live: dev instance with SLACK_ACK_EMOJI=galaxy_brain reacted :galaxy_brain: to an incoming DM before the reply. Co-Authored-By: QM <noreply@ycombinator.com>
Auto-fixed by watch-pipeline
…erride is set; disallow apostrophe in ack emoji names
…rg admin setting with emoji picker
16francej
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
SLACK_ACK_EMOJIenvironment variable with an org-level admin setting, configurable from the admin panel with an emoji picker fed by the workspace's own emoji list.How it works
ack-emoji— persisted per org scope (PersistedAckEmojiartifact), read/written through the standard admin scope-config resources (GET/PUT, clearable). Values are validated with the sameparseAckEmojirules (name syntax, de-dup, cap).GET /v1/admin/slack-emoji— new admin endpoint proxying Slackemoji.list(alias entries filtered out) so the picker can offer the workspace's custom emoji with previews.SlackCoreClient.ackEmojiOverride()with a 60s cache and passes it to the ack picker and turn handler as a callback; changes take effect without a restart (warmed at startup).SLACK_ACK_EMOJIremoved — one knob, no env/setting precedence rules.Known limitation
wave::skin-tone-3) is not accepted by the name validator (advisory from review; unchanged behavior).Tests
test/slack-ack-emoji.test.tsrewritten: parse rules, config-store roundtrip, live override behavior, defaults, presenter.test/slack-index.integration.test.tsupdated for the core-client override.