Fixed ReadPartitionSession closing#656
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
============================================
- Coverage 71.38% 71.37% -0.01%
Complexity 3375 3375
============================================
Files 379 379
Lines 15933 15936 +3
Branches 1670 1672 +2
============================================
+ Hits 11374 11375 +1
Misses 3909 3909
- Partials 650 652 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnv1
reviewed
May 28, 2026
There was a problem hiding this comment.
AI Review Summary
Verdict: ✅ No critical issues found
Critical issues
No critical issues found.
Other findings
- Minor | Medium:
ConcurrentLinkedQueueweakly consistent iterator instop()may miss concurrent additions and does not drain the queue —ReadPartitionSession.java:78 - Nit | High:
batch.getReadFuture().complete(null)should usebatch.complete()for consistency —ReadPartitionSession.java:79 - Minor | Low: Removed debug-level log from
send()creates asymmetry with the receive path that still logs at DEBUG —SessionBase.java:91
This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
|
Analysis performed by claude, claude-opus-4-6. |
pnv1
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.