Skip to content

Fixed ReadPartitionSession closing#656

Merged
alex268 merged 1 commit into
ydb-platform:masterfrom
alex268:master
May 28, 2026
Merged

Fixed ReadPartitionSession closing#656
alex268 merged 1 commit into
ydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Copy Markdown
Member

@alex268 alex268 commented May 28, 2026

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.37%. Comparing base (fdecb35) to head (3f8d185).

Files with missing lines Patch % Lines
...tech/ydb/topic/read/impl/ReadPartitionSession.java 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
- Coverage     71.38%   71.37%   -0.01%     
  Complexity     3375     3375              
============================================
  Files           379      379              
  Lines         15933    15936       +3     
  Branches       1670     1672       +2     
============================================
+ Hits          11374    11375       +1     
  Misses         3909     3909              
- Partials        650      652       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@robot-vibe-db robot-vibe-db Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

  • Minor | Medium: ConcurrentLinkedQueue weakly consistent iterator in stop() may miss concurrent additions and does not drain the queue — ReadPartitionSession.java:78
  • Nit | High: batch.getReadFuture().complete(null) should use batch.complete() for consistency — ReadPartitionSession.java:79
  • Minor | Low: Removed debug-level log from send() creates asymmetry with the receive path that still logs at DEBUG — SessionBase.java:91

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

Comment thread topic/src/main/java/tech/ydb/topic/read/impl/ReadPartitionSession.java Outdated
Comment thread topic/src/main/java/tech/ydb/topic/impl/SessionBase.java
@robot-vibe-db
Copy link
Copy Markdown

robot-vibe-db Bot commented May 28, 2026

Full analysis log

Analysis performed by claude, claude-opus-4-6.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@alex268 alex268 merged commit 4c33764 into ydb-platform:master May 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants