Skip to content

feat OTel: added support pool metrics#658

Open
KirillKurdyukov wants to merge 3 commits into
masterfrom
feat/metrics-v2
Open

feat OTel: added support pool metrics#658
KirillKurdyukov wants to merge 3 commits into
masterfrom
feat/metrics-v2

Conversation

@KirillKurdyukov
Copy link
Copy Markdown
Contributor

No description provided.

@KirillKurdyukov KirillKurdyukov requested a review from alex268 June 3, 2026 13:02
@KirillKurdyukov KirillKurdyukov changed the title feat: otel metrics v2 feat: otel metrics Jun 3, 2026
@KirillKurdyukov KirillKurdyukov changed the title feat: otel metrics feat OTel: added support rpc and pool metrics Jun 3, 2026
@KirillKurdyukov KirillKurdyukov changed the title feat OTel: added support rpc and pool metrics feat OTel: added support pool metrics Jun 4, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 80.74074% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.54%. Comparing base (96c33c2) to head (7a5e339).

Files with missing lines Patch % Lines
...main/java/tech/ydb/query/impl/QueryClientImpl.java 33.33% 7 Missing and 1 partial ⚠️
...java/tech/ydb/core/metrics/OpenTelemetryMeter.java 82.35% 1 Missing and 5 partials ⚠️
...in/java/tech/ydb/table/impl/PooledTableClient.java 50.00% 5 Missing ⚠️
...ore/src/main/java/tech/ydb/core/metrics/Meter.java 25.00% 3 Missing ⚠️
...main/java/tech/ydb/query/impl/TableClientImpl.java 0.00% 2 Missing ⚠️
...in/java/tech/ydb/core/metrics/DoubleHistogram.java 0.00% 1 Missing ⚠️
...c/main/java/tech/ydb/core/metrics/LongCounter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #658      +/-   ##
============================================
+ Coverage     71.42%   71.54%   +0.12%     
- Complexity     3373     3406      +33     
============================================
  Files           379      385       +6     
  Lines         15936    16064     +128     
  Branches       1672     1684      +12     
============================================
+ Hits          11382    11493     +111     
- Misses         3903     3917      +14     
- Partials        651      654       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KirillKurdyukov KirillKurdyukov force-pushed the feat/metrics-v2 branch 3 times, most recently from e927737 to 6d2859b Compare June 5, 2026 10:39
@KirillKurdyukov KirillKurdyukov added SLO and removed SLO labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🌋 SLO Test Results

🟢 1 workload(s) tested — All thresholds passed

Commit: 3552a1f · View run

Workload Thresholds Duration Report
java-query-kv 🟢 OK 10m 4s 📄 Report

Generated by ydb-slo-action

Add Meter/PoolMetrics instrumentation for table and query session pools.
Test OpenTelemetry plugin in core; cover pool metrics with unit tests.
Align mockito dependency setup with topic module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants