Skip to content

Build fixes#660

Merged
alex268 merged 5 commits into
ydb-platform:masterfrom
alex268:master
Jun 5, 2026
Merged

Build fixes#660
alex268 merged 5 commits into
ydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Copy Markdown
Member

@alex268 alex268 commented Jun 5, 2026

No description provided.

Comment thread .github/workflows/slo.yml Outdated
Comment thread pom.xml
@robot-vibe-db
Copy link
Copy Markdown

robot-vibe-db Bot commented Jun 5, 2026

AI Review Summary

Verdict: ❌ 0 critical issues found, 1 major issue found

Critical issues

No critical issues found.

Other findings

  • Major | High: The remove-slo-label job only has pull-requests: write permission, but the newly added actions/checkout@v5 step requires contents: read to clone the repository. The checkout will fail, breaking SLO label removal. — .github/workflows/slo.yml:150
  • Nit | High: Accidental extra leading space on the <plugin> tag for maven-compiler-plugin (21 spaces vs 20 for sibling element) — pom.xml:269

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

@robot-vibe-db
Copy link
Copy Markdown

robot-vibe-db Bot commented Jun 5, 2026

Full analysis log

Analysis performed by claude, claude-opus-4-6.

KirillKurdyukov
KirillKurdyukov previously approved these changes Jun 5, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.44%. Comparing base (417e29b) to head (fb04642).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #660      +/-   ##
============================================
+ Coverage     71.43%   71.44%   +0.01%     
+ Complexity     3374     3373       -1     
============================================
  Files           379      379              
  Lines         15936    15936              
  Branches       1672     1672              
============================================
+ Hits          11384    11386       +2     
  Misses         3901     3901              
+ Partials        651      649       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 merged commit 96c33c2 into ydb-platform:master Jun 5, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants