Close in-flight reader stream when create() is cancelled#836
Merged
Conversation
Prevents a zombie gRPC read session holding the partition when reader.close() interrupts ReaderStream.create() mid-reconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
reader.close()cancels the connection loop whileReaderStream.create()is in flight (gRPC stream opened, init sent) but before it is assigned to the reconnector, the connection-loopfinallycan't reach the half-built stream. It is orphaned: the gRPC read session stays open and keeps the consumer's partition, so a fresh reader never gets it assigned and appears hung. This is the gap left by #835.Fix
Wrap
create()'sstream.start+_startintry/exceptthat closes the in-flight stream before re-raising.Also surfaces reconnector and read session ids on every reader log line for easier correlation across reconnects.