Skip to content

Fix dialect import on SQLAlchemy 1.4 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvoleg merged 1 commit into from
Jun 2, 2026
Merged

Fix dialect import on SQLAlchemy 1.4 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Fix dialect import failure on SQLAlchemy 1.4 (drop kwargs annotation on view reflection methods)

## 0.1.20 ##
* Support YDB view reflection

Expand Down
4 changes: 2 additions & 2 deletions ydb_sqlalchemy/sqlalchemy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,14 @@ def _describe_table(self, connection, table_name, schema=None) -> ydb.TableDescr
raise NoSuchTableError(qt) from e

@reflection.cache
def get_view_names(self, connection, schema=None, **kw: Any):
def get_view_names(self, connection, schema=None, **kw):
self._ensure_schema_unsupported(schema)

raw_conn = connection.connection
return raw_conn.get_view_names()

@reflection.cache
def get_view_definition(self, connection, view_name, schema=None, **kw: Any):
def get_view_definition(self, connection, view_name, schema=None, **kw):
self._ensure_schema_unsupported(schema)

quoted_view_name = self.identifier_preparer.quote(view_name)
Expand Down
Loading