Ignore table schema (fixes #114)#115
Merged
Merged
Conversation
YDB connections are bound to a single database and have no schema namespaces (supports_schemas=False). Accept and ignore the schema argument in reflection, and never emit a schema qualifier when compiling SQL, so generic two-tier SQLAlchemy tooling works.
vgvoleg
force-pushed
the
issue-114-ignore-schema
branch
from
8863cc5 to
429002c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YDB connections are bound to a single database with no schema namespaces (
supports_schemas=False).schemaargument and always targets the connected database.visit_table/format_table), so a table reflected withschema=<database>no longer compiles to an unresolvabledb.tablepath.This unblocks generic two-tier SQLAlchemy tooling (e.g. DataHub) that passes the bound database as
schema.Closes #114