#16: own stack values in consuming iterator#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16.
Summary:
IntoIterator for Stackso consuming iteration owns the fixed arrayIntoIter::next()and copy values directly by indexValidation:
cargo test --all-features-> 23 unit tests and 2 doctests passed on currentmasterbefore this patch, confirming Baseline build is red on master:#[must_use]on trait-impl methods and elided-lifetime warnings now errors under stable rustc #70 no longer reproduces locally withrustc 1.94.1.cargo --color=never fmt --check-> passedcargo --color=never test --all-features-> 23 unit tests and 2 doctests passedcargo --color=never test --release --all-features-> 23 unit tests and 2 doctests passedcargo --color=never doc --no-deps-> passedgit diff --check-> passedgit diff | gitleaks stdin --redact --no-banner --exit-code 1-> no leaks foundNot run locally:
cargo clippy: this environment does not have the Cargo clippy subcommand installed.rustup run nightly cargo bench:rustupis not installed here, so the official nightly benchmark command could not be run locally.