This repository was archived by the owner on Mar 26, 2018. It is now read-only.
Let you add flags for folder paths#279
Open
LasseSviland wants to merge 3 commits intoyeoman:masterfrom
Open
Conversation
… and bower_components
| var pathToBowerComponents; | ||
| var pathToApp; | ||
|
|
||
| // Let yoy spesify a path to the app folder |
There was a problem hiding this comment.
There is a typo: yoy spesify should be you specify. Same mistake at lines 108 and 122.
| pathToApp = this.flags.app; | ||
|
|
||
| // adding / to the end of the path | ||
| if (pathToApp.charAt(pathToApp.length - 1) !== '/' ) { |
Contributor
There was a problem hiding this comment.
Have you tested this in Windows? I'm not sure if it'll work as written because they use \ file paths
Author
There was a problem hiding this comment.
In the previous code it do also have the / hardcoded.
pathToEl = path.join(this.destinationPath('app/elements'), this.flags.path);
I have only moved the hardcoded values out to variables that can be changed with the flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed my project a bit and made some changes to still be able to use the generator, maybe someone else will have use for it as well :)
Let you use optional flags to specify the path to the app folder, elements folder and bower_components for the element generator, it will not do any changes to the current behavior.
This way you can still use the generator without needing to have all the same setup as the default.
usage:
yo polymer:el my-element --app="path/to/my/app/folder"Let you specify the path to the app folder, or use current directory by setting --app to "."
yo polymer:el my-element --elements="my_elements"Let you specify a path to the elements folder relative to the app folder, or use the app folder by setting --elements to "."
yo polymer:el my-element --bower="my_bower_components"Let you specify a path to the bower_components folder relative to the app folder.