Criteria Expression Walker/Visitor#39
Merged
Merged
Conversation
cliffcaseyyet
left a comment
cliffcaseyyet
left a comment
Member
There was a problem hiding this comment.
In general I like the approach of the walker pattern and how it's handling everything and reducing cruft. More specifically, though, I suspect there are more java-idiomatic ways to solve it. Needs discussion
| String activeCacheClass) { | ||
| } | ||
|
|
||
| private static final ExpressionWalker.Visitor<ReferenceState> REFERENCE_VISITOR = |
Member
There was a problem hiding this comment.
This inline extension syntax is bananas. Let's just make a Visitor abstract superclass and then a subclass for Reference?
| } | ||
|
|
||
| /** Receives each expression and optionally derives state for each child edge. */ | ||
| @FunctionalInterface |
Member
There was a problem hiding this comment.
what in tarnation? See other comment. I might need to hear a broader case for this methodology.
| import java.util.List; | ||
|
|
||
| public class LogicalExpression implements Expression { | ||
| public final class LogicalExpression implements Expression { |
cliffcaseyyet
approved these changes
Jul 24, 2026
milt
marked this pull request as ready for review
July 24, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A speculative refactor that introduces a walker pattern to replace the quasi-repetitive recursive traversal code we have all over the place